Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pnpm to Replace Yarn #1082

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use pnpm to Replace Yarn #1082

wants to merge 9 commits into from

Conversation

TakumiBC
Copy link
Member

pnpm has a better efficiency compared to yarn. It will increase the speed of our package management, and also speed up builds.
I have also created a .eslintignore file to let ESLint ignore files like README.md.

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024

@TakumiBC is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ❌ Failed (Inspect) Feb 22, 2024 8:36am

@maxwofford
Copy link
Member

Hey @TakumiBC, thanks for the interest in maintaining the repo!

We use yarn because we've tried pnpm before in other repos and run into issues on virtual and syncing filesystems like dropbox. Considering our builds don't take that long to spin up in production and run fine on an m1 macbook when running yarn dev, I don't think we're looking to change package managers currently.

@aramshiva
Copy link
Member

Fixes #1042

@maxwofford
Copy link
Member

I'll move the discussion there!

@maxwofford maxwofford mentioned this pull request Feb 24, 2024
Open
grymmy
grymmy requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts and re-ping me.

@TakumiBC
Copy link
Member Author

TakumiBC commented Apr 3, 2024

@grymmy Fixed the conflicts. Please help me approve the Vercel build.

@TakumiBC TakumiBC requested a review from grymmy April 3, 2024 14:35
@grymmy
Copy link
Contributor

grymmy commented Apr 3, 2024

Can you please provide the actual build speed gains realized from this change? How much faster is it with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grymmy grymmy Awaiting requested review from grymmy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TakumiBC @maxwofford @aramshiva @grymmy